Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data is being corrupted when we perform some row alterations [urgent] #8614

Closed
AMBudnik opened this issue Aug 3, 2021 · 2 comments · Fixed by #8685
Closed

Data is being corrupted when we perform some row alterations [urgent] #8614

AMBudnik opened this issue Aug 3, 2021 · 2 comments · Fixed by #8685
Assignees
@wszymanski
Labels
bug Nested rows Plugin Status: Released

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented Aug 3, 2021 •
edited

Description

Data is being corrupted when we perform some row alterations.

Steps to reproduce

  • Right-click any row e.g. “Milk Curd” and click on Insert child row
  • Right-click the newly added row and click Remove Row.
  • Right-click any parent e.g. “Mix” and click Insert child row.

Result: The recently deleted row/rows re-appear and the last item is missing (Date Syrup).

reproduction

Demo

https://jsfiddle.net/oyakcvjn/ v 9.0.2 - broken

Your environment

  • Handsontable version: 9.0.2
  • Browser Name and version: Chrome 91
  • Operating System: Windows 10

Inform Zen # 26480
@wszymanski wszymanski self-assigned this Aug 18, 2021
@AMBudnik AMBudnik changed the title Data is being corrupted when we perform some row alterations Data is being corrupted when we perform some row alterations [urgent] Aug 23, 2021
wszymanski added a commit that referenced this issue Aug 30, 2021
@wszymanski
Renamed hook and changed how it works #8614
407ec7d
@wszymanski wszymanski mentioned this issue Aug 31, 2021
Merged
10 tasks
wszymanski added a commit that referenced this issue Aug 31, 2021
@wszymanski
Added test for use case corrupting a dataset #8614
6877f9c
wszymanski added a commit that referenced this issue Aug 31, 2021
@wszymanski
Added entry to the changelog #8614
3ac25c1
@wszymanski wszymanski linked a pull request Sep 13, 2021 that will close this issue
Data won't be corrupted anymore when there are performed some alterations #8685
Merged
10 tasks
@AMBudnik
Copy link
Contributor Author

Thank you for fixing it @wszymanski

I did not reproduce the issue using v10.

@aninde
Copy link
Contributor

aninde commented Sep 29, 2021

This issue will be fixed by v10 https://jsfiddle.net/wugf58eq/.
However, after step 1 header is truncated on v9.0.2 and v10. This case will be reported separately.

@AMBudnik AMBudnik mentioned this issue Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wszymanski wszymanski

Labels
bug Nested rows Plugin Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Data won't be corrupted anymore when there are performed some alterations handsontable/handsontable
3 participants
@wszymanski @AMBudnik @aninde