Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete definition(TS) and documentation for selectOptions property #8488

Closed
AMBudnik opened this issue Jul 29, 2019 · 3 comments · Fixed by #8647
Closed

Incomplete definition(TS) and documentation for selectOptions property #8488

AMBudnik opened this issue Jul 29, 2019 · 3 comments · Fixed by #8647
Assignees
Labels
Cell type: Select Docs: Content Issues related to Handsontable's documentation content Status: Released TypeScript

Comments

@AMBudnik
Copy link
Contributor

The selectOptions from the select cell type are also able to understand an array of numbers - not only strings.

 {
        editor: 'select',
        selectOptions: [5.8,8,9,6.5]
},

image

We should add the missing tag to the documentation and alter the definition file.

@AMBudnik
Copy link
Contributor Author

AMBudnik commented May 13, 2021

We are also missing the

@mrpiotr-dev mrpiotr-dev changed the title Add missing information about selectOptions Incomplete definition(TS) and documentation for selectOptions property Jul 14, 2021
@mrpiotr-dev
Copy link
Contributor

As I mentioned in handsontable/docs#64 - we don't need to add numbers. However, we have incomplete the following things:

  • TS definition - missing information about supported types mentioned in the above comment
  • JSDocs in metaSchema - missing information about supported types mentioned in the above comment

@mrpiotr-dev mrpiotr-dev added the Docs: Content Issues related to Handsontable's documentation content label Jul 14, 2021
@mrpiotr-dev mrpiotr-dev transferred this issue from another repository Jul 14, 2021
@mrpiotr-dev mrpiotr-dev self-assigned this Aug 16, 2021
@mrpiotr-dev mrpiotr-dev linked a pull request Aug 17, 2021 that will close this issue
2 tasks
mrpiotr-dev pushed a commit that referenced this issue Aug 19, 2021
* #8488 - Adds missing typescript definition, JSDocs and test for 'selectOptions'.

* #8488 - Adds changelog file and fixes E2E test's spec.

* Apply suggestions from code review

Co-authored-by: kirszenbaum <jakub.wisniewski@handsontable.com>

Co-authored-by: Piotr Laszczkowski <swistach@Piotrs-MacBook-Pro.local>
Co-authored-by: kirszenbaum <jakub.wisniewski@handsontable.com>
@AMBudnik
Copy link
Contributor Author

Thank you for adding. Closed as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cell type: Select Docs: Content Issues related to Handsontable's documentation content Status: Released TypeScript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants