Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested headers with sorting breaks dropdown menu #8232

Closed
aninde opened this issue Jun 16, 2021 · 3 comments · Fixed by #8639
Closed

Nested headers with sorting breaks dropdown menu #8232

aninde opened this issue Jun 16, 2021 · 3 comments · Fixed by #8639
Assignees
@wszymanski
Labels
bug Column sorting Plugin Dropdown menu Plugin Multi-column sorting Plugin Nested headers Plugin Status: Released

Comments

@aninde
Copy link
Contributor

aninde commented Jun 16, 2021

Description

When nested headers are used with sorting, the dropdown menu doesn't close itself, although it should when I sort the table.

Kapture 2021-06-16 at 15 51 51

Steps to reproduce

  1. Open the dropdown menu on column A.
  2. Sort column B or C.

Demo

https://jsfiddle.net/aninde/nc79qbxg/ v2.0.0

Your environment

  • Handsontable version: 2+
  • Browser Name and version: Chrome 92.0.4515.51
  • Operating System: macOS 11.2.3 (20D91)
@aninde aninde mentioned this issue Jun 16, 2021
Closed
@wszymanski wszymanski self-assigned this Aug 9, 2021
wszymanski added a commit that referenced this issue Aug 12, 2021
@wszymanski
Removed unnecessary conditional & refactored test & added extra checks …
65aa063 
…#8232
@wszymanski
Copy link
Contributor

wszymanski commented Aug 12, 2021 •
edited

Another use case:

bug.mp4

The bug is related to redrawing clicked element (headers are re-rendered).

wszymanski added a commit that referenced this issue Aug 13, 2021
@wszymanski
Extra e2e tests for fixed bug #8232
729c5ed
wszymanski added a commit that referenced this issue Aug 13, 2021
@wszymanski
Missing opening drop-down action for test #8232
d565ed5
wszymanski added a commit that referenced this issue Aug 13, 2021
@wszymanski
Just small change #8232
4a9d694
@wszymanski wszymanski mentioned this issue Aug 13, 2021
Merged
10 tasks
@wszymanski wszymanski linked a pull request Aug 13, 2021 that will close this issue
Fixed cooperation of drop-down menu and column sorting (closing menu on click) #8639
Merged
10 tasks
wszymanski added a commit that referenced this issue Aug 16, 2021
@wszymanski
Added entry to CHANGELOG & removed not passing test #8232
b929137
@aninde
Copy link
Contributor Author

aninde commented Sep 29, 2021

This issue will be fixed by v10 https://jsfiddle.net/knp1gvyx/.

@AMBudnik
Copy link
Contributor

Thank you for confirmation, @aninde
Closed as done.

@AMBudnik AMBudnik mentioned this issue Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wszymanski wszymanski

Labels
bug Column sorting Plugin Dropdown menu Plugin Multi-column sorting Plugin Nested headers Plugin Status: Released
Projects
None yet
Milestone
No milestone
3 participants
@wszymanski @AMBudnik @aninde