Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.4.0] Click inconsistency within the Filter Values component #8196

Closed
budnix opened this issue Jun 11, 2021 · 2 comments
Closed

[8.4.0] Click inconsistency within the Filter Values component #8196

budnix opened this issue Jun 11, 2021 · 2 comments
Labels
bug Cell type: Checkbox Filtering Plugin Regression Issues that were created while adding new changes to the source code Status: Released

Comments

@budnix
Copy link
Member

budnix commented Jun 11, 2021

Description

The items within the Values Component of the Filters plugin work inconsistently. When the cursor is over the checkbox element it can be toggled by a single click. When the cursor is next to it you need to double-click to change the state.

Kapture 2021-06-11 at 14 23 51

Demo

https://handsontable.com/docs/9.0.0/demo-filtering.html

Your environment

  • Handsontable version: 8.4.0 and later
  • Browser Name and version: -
  • Operating System: -
@budnix budnix added Regression Issues that were created while adding new changes to the source code bug Filtering Plugin Cell type: Checkbox labels Jun 11, 2021
wszymanski added a commit that referenced this issue Jun 11, 2021
@wszymanski
Fixed problems for Filters plugin & added tests for checkbox type cells
af4441a 
#8196
wszymanski added a commit that referenced this issue Jun 11, 2021
@wszymanski
Added CHANGELOG entry #8196
80aeed9
@wszymanski wszymanski mentioned this issue Jun 11, 2021
Merged
10 tasks
wszymanski added a commit that referenced this issue Jun 11, 2021
@wszymanski
Minor changes #8196
f860fa0
wszymanski added a commit that referenced this issue Jun 14, 2021
@wszymanski
Introduced new CSS style for cells of checkbox type to restore prev…
d060542 
…ious behaviour. (#8202)

* Fixed problems for Filters plugin & added tests for checkbox type cells #8196

* Added CHANGELOG entry #8196

* Minor changes #8196
@aninde
Copy link
Contributor

aninde commented Jun 14, 2021

This issue is fixed on vRC-9.0.1 https://jsfiddle.net/aninde/zm7qgrx2/

v9.0.1
Screenshot 2021-06-14 at 16 22 30

Was in v8.4.0
Screenshot 2021-06-14 at 16 21 36

@aninde
Copy link
Contributor

aninde commented Jun 17, 2021 •
edited

Works well with v9.0.1 https://jsfiddle.net/aninde/tnra9bzo/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Cell type: Checkbox Filtering Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@budnix @AMBudnik @aninde