Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parents of nested rows are expanded when we add a row [Urgent] #8181

Closed
AMBudnik opened this issue Jun 10, 2021 · 3 comments · Fixed by #8713
Closed

Parents of nested rows are expanded when we add a row [Urgent] #8181

AMBudnik opened this issue Jun 10, 2021 · 3 comments · Fixed by #8713

Comments

@AMBudnik
Copy link
Contributor

Description

Parents of nested rows are expanded when we add a row.

Steps to reproduce

  1. Collapse Best Metal Performance and Best Rock Song parents
  2. Use context menu to Insert row above on the row below the collapsed parents (Best Rock)

Result
Parents are expaded.
issue

Demo

https://jsfiddle.net/e3051krc/ 9.0.0 - broken
https://jsfiddle.net/b6qy0h79/3/ 8.0.0 - broken
https://jsfiddle.net/e3051krc/1/ 7.4.2 - broken (it was adding a bug in the console)
https://jsfiddle.net/e3051krc/3/ 7.0.0 - broken (it was adding a bug in the console)

Your environment

  • Handsontable version: 9.0.0
    It doesn't seem to be a regression
  • Browser Name and version: Chrome 91
  • Operating System: Windows 10

Inform Zen 26480 p2.

@wszymanski wszymanski self-assigned this Aug 18, 2021
@AMBudnik
Copy link
Contributor Author

Scenario 2 - required to work after fix

  • Go to https://jsfiddle.net/4980emLp/
  • Right Click “Lynchee Puree” and choose Insert child row from the context menu.
  • Collapse “Lynchee Puree”
  • Right-click “Milk Curd” and choose Insert row below from the context menu.

Result: The collapsed “Lynchee Puree” expanded.

bug2

@krzysztofspilka krzysztofspilka changed the title Parents of nested rows are expanded when we add a row Parents of nested rows are expanded when we add a row [Urgent] Aug 23, 2021
wszymanski added a commit that referenced this issue Sep 16, 2021
@wszymanski wszymanski linked a pull request Sep 20, 2021 that will close this issue
10 tasks
@aninde
Copy link
Contributor

aninde commented Sep 29, 2021

This issue will be fixed by v10 https://jsfiddle.net/1pb2genm/.

@AMBudnik
Copy link
Contributor Author

True!

Also works well for the second scenario (the parent does not expand itself)

image

https://jsfiddle.net/95pz6y0r/2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants