Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.4.0] VUE - using alter() for adding rows adds too many rows #8148

Closed
AMBudnik opened this issue Jun 7, 2021 · 2 comments · Fixed by #8241
Closed

[8.4.0] VUE - using alter() for adding rows adds too many rows #8148

AMBudnik opened this issue Jun 7, 2021 · 2 comments · Fixed by #8241
Assignees
@jansiegel
Labels
bug Regression Issues that were created while adding new changes to the source code Status: Released Vue Issues regarding the @handsontable/vue wrapper.

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented Jun 7, 2021 •
edited

Description

Adding a new adds additional row at the bottom of the table. This issue does not occur in Angular or React wrappers, nor in the Vanilla version.

Calling alter() works the same as the context menu https://jsfiddle.net/7qm4rbxL/

Steps to reproduce

  1. Add a new row via context menu for the 2nd row

Result
You get two new rows added (one at the bottom of the table).

Demo

https://jsfiddle.net/m826w9b7/ 9.0.0 - still broken
https://jsfiddle.net/n2qsh4fx/1/ 8.4.0 - broken
https://jsfiddle.net/1naqwrLz/2/ 8.3.2 - works well

Your environment

  • Vue wrapper version: 8.4.0
  • Handsontable version: 8.4.0
  • Browser Name and version: Chrome 90
  • Operating System: Windows 10

Inform Zen 26478
@AMBudnik AMBudnik added bug Regression Issues that were created while adding new changes to the source code Vue Issues regarding the @handsontable/vue wrapper. labels Jun 7, 2021
@AMBudnik AMBudnik mentioned this issue Jun 7, 2021
Closed
@jansiegel jansiegel self-assigned this Jun 17, 2021
jansiegel added a commit that referenced this issue Jun 17, 2021
@jansiegel
- Revert changes from #7720 in favor of reading the source data direc…
9754606 
…tly from the instance. #8148
@jansiegel jansiegel mentioned this issue Jun 17, 2021
Merged
11 tasks
@jansiegel jansiegel linked a pull request Jun 17, 2021 that will close this issue
Make the Vue wrapper react properly to the alter-based CRUD actions. #8241
Merged
11 tasks
@AMBudnik AMBudnik mentioned this issue Jun 22, 2021
Closed
jansiegel added a commit that referenced this issue Jun 23, 2021
@jansiegel
Add a test case for external dataset size modification. #8148
e721756
@AMBudnik AMBudnik mentioned this issue Jun 28, 2021
Closed
jansiegel added a commit that referenced this issue Jun 28, 2021
@jansiegel
Make the Vue wrapper react properly to the alter-based CRUD actions. (#…
3155988 
…8241)

* - Revert changes from #7720 in favor of reading the source data directly from the instance. #8148

* Add a test case for external dataset size modification. #8148
@AMBudnik AMBudnik mentioned this issue Jul 1, 2021
Closed
@aninde
Copy link
Contributor

aninde commented Jul 22, 2021

This issue will be fixed by the v9.0.2 https://jsfiddle.net/8cekL23w/

@mrpiotr-dev mrpiotr-dev mentioned this issue Jul 28, 2021
Closed
@mrpiotr-dev
Copy link
Contributor

I'm happy to announce we just released v9.0.2 with the fix to this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansiegel jansiegel

Labels
bug Regression Issues that were created while adding new changes to the source code Status: Released Vue Issues regarding the @handsontable/vue wrapper.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the Vue wrapper react properly to the alter-based CRUD actions. handsontable/handsontable
4 participants
@jansiegel @AMBudnik @mrpiotr-dev @aninde