[9.0.0] Can't block autofill via beforeChange when using formulas

[AMBudnik]

Description

We are not able to block autofill when formulas are defined.

The issue should be fixed after handsontable/hyperformula#678

The issue does not occur when

• we use v8.4.0 https://jsfiddle.net/gp2ne5qz/2/
• we comment out formulas

Steps to reproduce

1. Autofill A1 to A2

Result in v8.4.0 and v9 without formulas
Cell A2 does not change its value - we still have 2017 in the cell.

Result in v9 with formulas enabled
Cell A2 changes its value - we have 2016 in the cell.

Demo

https://jsfiddle.net/xc5gqLn1/4/

Your environment

• Handsontable version: v9+
• Browser Name and version: Chrome 89
• Operating System: Windows 10

Test Zen 26993 after fix

[Siemienik]

Actually, Enabling the HyperFormula causes that we cannot prevent change the value:

With HF:

Without:

const container = document.getElementById('container');
    const hot = new Handsontable(container, {
      data: [
        [1, 999, 3, '=B1*500', '=B1*5'],
        [9, 8, 7, '=B2*500', '=B2*5'],
        [4, 6, 2, '=B3*500', '=B3*5'],
      ],
      type: 'numeric',
      rowHeaders: true,
      colHeaders: true,
      // formulas: {
      //   engine: HyperFormula
      // },
      beforeChange(changes, source) {
        changes[0] = null;
      }
    });

[rsify]

The problem seems to be related to the fact that we're hooking up to beforeChange in the formulas plugin, the callback to which will always run before any user defined hook. It used to be the case that the plugin used to work with modifyData instead before e8a8249, and it seems like the bug above didn't exist before that commit.

[rsify]

#8134

[rsify]

Looks like the problem described in #8107 (comment) was fixed in #8139, I'm changing the title back to the original one related to autofill only.

[wojciechczerniak]

@nikersify Isn't it fixed in #8129?

[rsify]

@wojciechczerniak I get an error every time I try to autofill using the latest build from that PR (0053371) 🤷

[rsify]

@wojciechczerniak never mind, I tested the commit (fecc19b) before the one that prepares for hyperformula@1.0 (60594b5) - I don't get an error anymore but this issue is not fixed by those changes.

[wojciechczerniak]

Ok. So this is a first good step, we will have data in beforeChange from HF, but we still use beforeChange to sync the changes with HF

[aninde]

This issue will be fixed by v10 https://jsfiddle.net/9h0soLvu/.

[AMBudnik]

Issue closed as fixed in v10