Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0.0] When we cause the formula to throw a #REF! error with an action undoing it doesn't clear the error #8078

Closed
AMBudnik opened this issue May 20, 2021 · 3 comments · Fixed by #8129
Closed

[9.0.0] When we cause the formula to throw a #REF! error with an action undoing it doesn't clear the error #8078

AMBudnik opened this issue May 20, 2021 · 3 comments · Fixed by #8129
Assignees
@wszymanski
Labels
bug Formulas Plugin Regression Issues that were created while adding new changes to the source code Status: Released Undo-redo Plugin

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented May 20, 2021 •
edited

Description

When we cause the formula to throw a #REF! error with an action undoing it doesn't clear the error.

Might be related to #8076 (#8076 is solved in v9)

Steps to reproduce

  1. Remove first row with context menu (you get #REF! error which is correct)
  2. Use CMD/CTRL+Z to undo

v9 result
The error is still visible
ref_error_v9

v8.4.0
The error is gone
ref_error_v840

Demo

https://jsfiddle.net/handsoncode/e7z2dn0r/ v9 - broken
https://jsfiddle.net/handsoncode/8fkzv94w/ v8.4.0 (old formulas) - working well

Your environment

  • Handsontable version: 9+
  • Browser Name and version: Chrome 89
  • Operating System: Windows 10
@AMBudnik AMBudnik added bug Undo-redo Plugin Formulas Plugin Regression Issues that were created while adding new changes to the source code labels May 20, 2021
@aninde aninde mentioned this issue May 25, 2021
Closed
38 tasks
@wszymanski wszymanski self-assigned this May 27, 2021
@wszymanski
Copy link
Contributor

Second case (remove row + undo)

May-28-2021 15-03-05

@wszymanski wszymanski mentioned this issue May 28, 2021
Merged
11 tasks
wszymanski added a commit that referenced this issue May 28, 2021
@wszymanski
Handling undo/redo actions using HF UndoRedo mechanism #8078
11a5770
wszymanski added a commit that referenced this issue May 28, 2021
@wszymanski
Just one more comment for test #8078
5c0cb08
wszymanski added a commit that referenced this issue May 28, 2021
@wszymanski
One more comment #8078
a91242a
@wszymanski wszymanski mentioned this issue May 28, 2021
Merged
10 tasks
wszymanski added a commit that referenced this issue May 28, 2021
@wszymanski
Fixed problems found by linter #8078
c74ce02
wszymanski added a commit that referenced this issue May 28, 2021
@wszymanski
Removed comment #8078
3120e9b
@wszymanski wszymanski linked a pull request May 28, 2021 that will close this issue
Handling undo/redo actions using HF's UndoRedo mechanism #8078 #8129
Merged
10 tasks
wszymanski added a commit that referenced this issue May 31, 2021
@wszymanski
WIP: Workaround for the Autofill and tests #8078
b97225a
wszymanski added a commit that referenced this issue May 31, 2021
@wszymanski
Extra tests & tests reorganization #8078
450f735
wszymanski added a commit that referenced this issue Jun 2, 2021
@wszymanski
Fixed problem related to a workaround in the Autofill plugin - expose…
65f129f 
…d problem by new code #8078
wszymanski added a commit that referenced this issue Jun 4, 2021
@wszymanski
Undo/redo works properly for setDataAtCell action for multiple cells …
48b5a80 
…#8078
wszymanski added a commit that referenced this issue Jun 4, 2021
@wszymanski
Fixed problem found by linter #8078
fecc19b
wszymanski added a commit that referenced this issue Jun 8, 2021
@wszymanski
Prepared code for HF 1.0 - removed workaround related to UndoRedo, re…
60594b5 
…moved workaround in the Autofill plugin (using getFillRangeData method) #8078
wszymanski added a commit that referenced this issue Jun 8, 2021
@wszymanski
Remomed unnecessary import #8078
0053371
@wojciechczerniak wojciechczerniak mentioned this issue Jul 15, 2021
Closed
36 tasks
wszymanski added a commit that referenced this issue Jul 20, 2021
@wszymanski
Updated dependency (breaking change) + synced with develop (WIP) #8078
0a369b9
wszymanski added a commit that referenced this issue Jul 20, 2021
@wszymanski
WIP: Removed redundant code #8078
91533e2
wszymanski added a commit that referenced this issue Sep 13, 2021
@wszymanski
Merged with develop #8078
b706d11
wszymanski added a commit that referenced this issue Sep 16, 2021
@wszymanski
Synchronized code with develop & removed unnecessary `hasFillDataChan…
1e4c9b3 
…ged` argument from `afterAutofill` hook #8078
wszymanski added a commit that referenced this issue Sep 16, 2021
@wszymanski
Small code formatting change & added entry to the changelog #8078
180ab71
wszymanski added a commit that referenced this issue Sep 16, 2021
@wszymanski
Added extra test case #8078
1bcaa97
wszymanski added a commit that referenced this issue Sep 17, 2021
@wszymanski
Fixed problem related to column creation done by the UndoRedo plugin #…
a067829 
…8078
wszymanski added a commit that referenced this issue Sep 17, 2021
@wszymanski
Removed unnecessary console log and added extra test for fixed bug #8078
3289c63
wszymanski added a commit that referenced this issue Sep 17, 2021
@wszymanski
Added extra comment for part of the code #8078
202b847
wszymanski added a commit that referenced this issue Sep 20, 2021
@wszymanski
Fixed found regression related to not handling row move actions by HF #…
1f0c4e4 
…8078
wszymanski added a commit that referenced this issue Sep 22, 2021
@wszymanski
Handling undo/redo actions using HF's UndoRedo mechanism #8078 (#8129)
102b3bc
@aninde
Copy link
Contributor

aninde commented Sep 29, 2021

This issue will be fixed by v10 https://jsfiddle.net/Ljbvu57d/.

@AMBudnik
Copy link
Contributor Author

I'm glad to see both of those issues solved. Closed as done.

@AMBudnik AMBudnik mentioned this issue Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wszymanski wszymanski

Labels
bug Formulas Plugin Regression Issues that were created while adding new changes to the source code Status: Released Undo-redo Plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handling undo/redo actions using HF's UndoRedo mechanism #8078 handsontable/handsontable
3 participants
@wszymanski @AMBudnik @aninde