Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The datePickerConfig is inherited by other date type columns that are opened after the one with the datePickerConfig defined. #6636

Closed
AMBudnik opened this issue Jan 14, 2020 · 2 comments · Fixed by #8679
Closed

The datePickerConfig is inherited by other date type columns that are opened after the one with the datePickerConfig defined. #6636

AMBudnik opened this issue Jan 14, 2020 · 2 comments · Fixed by #8679
Labels
bug Cell type: Date Status: Released

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented Jan 14, 2020 •
edited by mrpiotr-dev

Description

The datePickerConfig is inherited by other date type columns that are opened after the one with the datePickerConfig defined.

Steps to reproduce

Case 1

Open them one after another

  1. Open date picker for column A. You should see one month. Correct!
  2. Open date picker for column B. You should see three months. Correct!
  3. Open date picker for column C. You should see one month. Incorrect!

GIF

Case 2

Open them from right to left

  1. Open date picker for column C. You should see one month. Correct!
  2. Open date picker for column B. You should see three months. Correct!
  3. Open date picker for column A. You should see three months. Incorrect!

GIF2

Case 3

Described in #5757

Additional information

  • it happens the same if we add more columns. It seems that the config is kept until the cell gets a new one.
  • passing empty object as the datePickerConfig doesn't reset the settings https://jsfiddle.net/u74az1dh/. I guess that we are looking for a certain option in the config and then apply it.

Demo

https://jsfiddle.net/f5w8vu2a/

Your environment

  • Handsontable version: 7.3.0
  • Browser Name and version: Chrome 79
  • Operating System: Windows 10

Inform FORUM-4023
Possibly related to #5757
@mrpiotr-dev mrpiotr-dev mentioned this issue Jan 26, 2021
Closed
mrpiotr-dev added a commit that referenced this issue Aug 25, 2021
@mrpiotr-dev
#6636 - WIP - Recreating date picker instead of config pollution in t…
300fa0a 
…he prototype.
@mrpiotr-dev mrpiotr-dev mentioned this issue Aug 25, 2021
Merged
2 tasks
@mrpiotr-dev mrpiotr-dev linked a pull request Aug 25, 2021 that will close this issue
Fixes resetting date picker's configuration #8679
Merged
2 tasks
mrpiotr-dev added a commit that referenced this issue Aug 26, 2021
@mrpiotr-dev
#6636 - Fixes errors found by linter
8c9f99d
mrpiotr-dev added a commit that referenced this issue Aug 26, 2021
@mrpiotr-dev
#6636 Adds missing changelog file
07de407
mrpiotr-dev added a commit that referenced this issue Sep 10, 2021
@mrpiotr-dev
#6636 - Reverts hideDatepicker()
09764b9
mrpiotr-dev added a commit that referenced this issue Sep 14, 2021
@mrpiotr-dev @swistach
Fixes resetting date picker's configuration (#8679)
a4ad311 
* #6636 - WIP - Recreating date picker instead of config pollution in the prototype.

* #6636 - Fixes errors found by linter

* #6636 Adds missing changelog file

* #6636 - Reverts hideDatepicker()

Co-authored-by: Piotr Laszczkowski <swistach@users.noreply.github.com>
@aninde
Copy link
Contributor

aninde commented Sep 29, 2021

This issue will be fixed by v10.
Demo http://jsfiddle.net/c931oj4u/ v10

@AMBudnik
Copy link
Contributor Author

AMBudnik commented Sep 29, 2021 •
edited

True. Cases 1 and 2 are solved in v10.
Case 3 was also solved, and updated in the separate issue listed above.

@AMBudnik AMBudnik mentioned this issue Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Cell type: Date Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes resetting date picker's configuration handsontable/handsontable
2 participants
@AMBudnik @aninde