-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incomplete blockCalculation feature for selection #4996
Comments
Still remains the same, for docs version 7.4.2. The documentation states that the 4th parameter of the However, the proper key is Demo https://jsfiddle.net/trhznf17/1/ Additionally, the 4th parameter is not well explained. Whatever I do they all seem to return This also applies to |
…es and the JSDoc description in all occurrences. Removes incorrect definition for beforeOnCellMouseUp #4996
…ges break the major version. #4996
…er` hooks. (#8591) * Replaces 'blockCalculation' with 'controller'. Unifies arguments' names and the JSDoc description in all occurrences. Removes incorrect definition for beforeOnCellMouseUp #4996 * Changes incorrect test for beforeOnCellMouseUp's TS definition. #4996 * Unifies cells/cell name convention in selection controller. That changes break the major version. #4996
Description
The documentation states that the
blockCalculation
contains onlyrow
andcolumn
but in fact, this object supports additionallycell
andcells
properties (https://github.com/handsontable/handsontable/blob/develop/src/selection/mouseEventHandler.js). The problem with this new properties is that they are used interchangeably in the source code and this should be standardized to use only thecell
property. The most of plugin what I found uses thecell
property.Your environment
The text was updated successfully, but these errors were encountered: