Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete blockCalculation feature for selection #4996

Closed
budnix opened this issue Apr 5, 2018 · 1 comment · Fixed by #8591
Closed

Incomplete blockCalculation feature for selection #4996

budnix opened this issue Apr 5, 2018 · 1 comment · Fixed by #8591
Assignees
Labels

Comments

@budnix
Copy link
Member

budnix commented Apr 5, 2018

Description

The documentation states that the blockCalculation contains only row and column but in fact, this object supports additionally cell and cells properties (https://github.com/handsontable/handsontable/blob/develop/src/selection/mouseEventHandler.js). The problem with this new properties is that they are used interchangeably in the source code and this should be standardized to use only the cell property. The most of plugin what I found uses the cell property.

Your environment

  • Handsontable version: 0.38.1
  • Browser Name and version: any
  • Operating System: any
@AMBudnik
Copy link
Contributor

AMBudnik commented May 5, 2020

Still remains the same, for docs version 7.4.2.

The documentation states that the 4th parameter of the beforeOnCellMouseDown callback is an object that shares row, column and cells objects

Zrzut ekranu 2020-05-5 o 10 58 28

However, the proper key is cell, so there's a typo

Zrzut ekranu 2020-05-5 o 11 00 59

Demo https://jsfiddle.net/trhznf17/1/

Additionally, the 4th parameter is not well explained. Whatever I do they all seem to return false.

This also applies to beforeOnCellMouseOver callback.

@scarletfog scarletfog self-assigned this Sep 10, 2020
@mrpiotr-dev mrpiotr-dev self-assigned this Jul 27, 2021
mrpiotr-dev added a commit that referenced this issue Jul 27, 2021
…es and the JSDoc description in all occurrences. Removes incorrect definition for beforeOnCellMouseUp #4996
mrpiotr-dev added a commit that referenced this issue Jul 28, 2021
mrpiotr-dev pushed a commit that referenced this issue Aug 16, 2021
…er` hooks. (#8591)

* Replaces 'blockCalculation' with 'controller'. Unifies arguments' names and the JSDoc description in all occurrences. Removes incorrect definition for beforeOnCellMouseUp #4996

* Changes incorrect test for beforeOnCellMouseUp's TS definition. #4996

* Unifies cells/cell name convention in selection controller. That changes break the major version. #4996
@krzysztofspilka krzysztofspilka changed the title Uncomplete blockCalculation feature for selection Incomplete blockCalculation feature for selection Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants