Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use entire parameter path as environment variable name #51

Merged
merged 1 commit into from Mar 3, 2022

Conversation

aereal
Copy link
Contributor

@aereal aereal commented Aug 17, 2021

BREAKING CHANGE: Parameters' uniqueness guaranteed by its entire path not only the last part of the path.

fix #50

BREAKING CHANGE: Parameters' uniqueness guaranteed by its entire path not only the last part of the path.
refs. handlename#50
@aereal
Copy link
Contributor Author

aereal commented Aug 31, 2021

@handlename How about this?

@handlename
Copy link
Owner

@aereal I'm sorry for no reaction for long time 🙇

Thank you for contributing!
It seems good, but this PR will change previous behavior.
So I'll add command line flag to use entire path after merge this PR.
Please wait for a moment.

@handlename handlename merged commit 5378683 into handlename:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implicitly discards parameters that have same base name but in other path hierarchy
2 participants