Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for sane npm install in CI #1592

Closed
nknapp opened this issue Oct 29, 2019 · 0 comments · Fixed by #1865
Closed

check for sane npm install in CI #1592

nknapp opened this issue Oct 29, 2019 · 0 comments · Fixed by #1865
Milestone
5.0.0

Comments

@nknapp
Copy link
Collaborator

nknapp commented Oct 29, 2019

We should add a build-step that tests for things like "unmet peer-dependencies" in the CI.

@skinny85 suggested in #1589 to run npm install and npm ls and look for warnings.

This probably needs to be done in a sibling directory in the Travis container in order to ignore to devDependencies coming from the handlebars.js package.json
@nknapp nknapp added this to the 5.0.0 milestone Apr 5, 2020
@jaylinski jaylinski changed the title check for sane npm install in Travis-CI check for sane npm install in CI Jan 2, 2022
jaylinski added a commit that referenced this issue May 20, 2022
@jaylinski
Add CI check for unmet dependencies
d395141 
Fixes #1592
@jaylinski jaylinski mentioned this issue May 20, 2022
Merged
jaylinski added a commit that referenced this issue May 20, 2022
@jaylinski
Add CI check for unmet dependencies
3f890b4 
Fixes #1592
jaylinski added a commit that referenced this issue May 20, 2022
@jaylinski
Add CI check for unmet dependencies
0872b78 
Fixes #1592
jaylinski added a commit that referenced this issue May 20, 2022
@jaylinski
Add CI check for unmet dependencies
e0de1d9 
Fixes #1592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Add CI check for unmet dependencies handlebars-lang/handlebars.js
1 participant
@nknapp