Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up a review process (volunteers please) #1591

Closed
nknapp opened this issue Oct 29, 2019 · 1 comment
Closed

Set up a review process (volunteers please) #1591

nknapp opened this issue Oct 29, 2019 · 1 comment

Comments

@nknapp
Copy link
Collaborator

nknapp commented Oct 29, 2019 •
edited

At the moment, I am reviewing pull requests from contributors and decide whether to merge it or not. That's ok since there are not too many PRs.

What I need is someone the review my PRs and check for errors that are not detected by the CI
(like #1589). At the moment, I just push some changes myself, because I know there are no other active collabators.

It would be great to know that there is a group of people that have the time and are willing to review (within a couple of days) PRs that I make myself.

Please answer if you would like to be that. I'll add you as reviewer for my next PR.

PS: My primary concern are obvious issues like #1589, but we can also discuss code-style if you like. But you don't have to.
@nknapp
Copy link
Collaborator Author

nknapp commented Apr 5, 2020

Closing this for now.

@nknapp nknapp closed this as completed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nknapp