Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move main development back to master-branch #1566

Open
nknapp opened this issue Sep 28, 2019 · 6 comments
Open

Move main development back to master-branch #1566

nknapp opened this issue Sep 28, 2019 · 6 comments
Milestone

Comments

@nknapp
Copy link
Collaborator

nknapp commented Sep 28, 2019

Currently, we are developing on the 4.x branch, but everything has to be merged into master to keep it maintainable. This is not a lot of work, but a little bit frustrating. I have taken the time and searched through both logs. The main differences (i.e. commits that are part of master and not 4.x are):

Breaking changes:

  • Remove stringParams and trackIds mode 3f77b82, 118836f
  • Remove semi-documented _setup and _child APIs, 63a0889
  • Remove amd files from the build, 8517352, 5302782
  • Remove support for Node <= 12 (no support for EOL versions)

Bugfixes

  • Use objects for hash value tracking, 768ddbd

Everything else if chore or docs. @wycats keeping these commits on master would require us to bump to 5.0. I would probably remove support for lambdas (#1565) as well, when doing that.

@rwjblue
Copy link
Contributor

rwjblue commented Oct 2, 2019

FWIW, I believe that the divergence between master and 4.x are partially to blame for the ergonomic regressions reported in #1562 (specific explanation in #1562 (comment)).

@nknapp
Copy link
Collaborator Author

nknapp commented Oct 6, 2019

Might be, yes I'm not 100% sure, but this is the only explanation I have

@nknapp nknapp mentioned this issue Nov 15, 2019
@marado
Copy link
Contributor

marado commented Dec 6, 2019

AFAICS, #1274 is also only merged on 5.0 but not on 4.x.

@nknapp
Copy link
Collaborator Author

nknapp commented Dec 8, 2019

Yes, that was before I told everyone to point PRs to the 4.x branch.

@ErisDS
Copy link
Collaborator

ErisDS commented Apr 3, 2020

The master branch now also uses yargs instead of optimist/minimist, and has dropped support for Node.js < v10

@nknapp nknapp added this to the 5.0.0 milestone Apr 5, 2020
@nknapp
Copy link
Collaborator Author

nknapp commented Apr 5, 2020

This is an implicit goal for 5.0, but the issue description documents parts of the changelog for 5.0, so I am assigning it to the milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants