Re-fix Erubi on Rails < 5.1 #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c0827b2.
|
Looks like there's still an issue with jruby-9.1.12.0. I'm working on it. |
|
@k0kubun this should be good to merge! |
|
It's a little complicated, but hopefully this check will be removed after supported Rails becomes higher. I love this well-documented patch. Thank you 👍 👍 👍 |
|
Sorry for not being able to release earlier, but just pubished 5.0.3 gem with this fix. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 10, 2017
## 5.0.3 Released on September 7, 2017 ([diff](haml/haml@v5.0.2...v5.0.3)). * Use `String#dump` instead of `String#inspect` to generate string literal. (Takashi Kokubun) * Fix Erubi superclass mismatch error. [#952](haml/haml#952) (thanks [Robin Daugherty](https://github.com/RobinDaugherty)) ## 5.0.2 Released on August 1, 2017 ([diff](haml/haml@v5.0.1...v5.0.2)). * Let `haml -c` fail if generated Ruby code is syntax error. [#880](haml/haml#880) (Takashi Kokubun) * Fix `NoMethodError` bug caused with Sprockets 3 and :sass filter. [#930](haml/haml#930) (thanks [Gonzalez Maximiliano](https://github.com/emaxi)) * Fix `list_of` helper with multi-line content. [#933](haml/haml#933) (thanks [Benoit Larroque](https://github.com/zetaben)) * Optimize rendering performance by changing timing to fix textareas. [#941](haml/haml#941) (Takashi Kokubun) * Fix `TypeError` with empty :ruby filter. [#942](haml/haml#942) (Takashi Kokubun) * Fix inconsistent attribute sort order. (Takashi Kokubun)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was attempted in #948, but we made a small change after the PR was first opened. Turns out we must use check for Erubi using
defined?and Rails' Erubi object usingconst_defined?.If we call
defined?with Rails's object, it gets defined by Rails. Callingconst_defined?with the constant as a string seems to be the only way for us to see if it's been defined without causing it to be defined.Without the
defined?in front of theconst_defined?call, Rails 4.2 raises a weird exception. Together, they seem to do the job.I've set Travis to require the erubi gemfile tests to pass.