Unexpected errors on empty filters

[f6p]

Hello,

after recent haml update (from 4.0.7 to 5.0.4) I noticed that filters may raise unexpected errors when there is no content. For example in 4.0 it was safe to have :css with no content. After update to 5.0 when :css have no content css filter will receive nil as text argument and will fail trying to do text.rstrip.

haml/lib/haml/filters.rb

Line 236 in c1b38ed

text = text.rstrip

It looks like previously strings were passed to filters but now if there is no content filter will receive nil instead. So some filters will raise unexpected errors while others won't depending on how they are implemented.

[dillonwelch]

It seems like maybe this could be solved with a deprecation warning/error? It shouldn't be surprising that major version upgrades come with breaking changes.

[k0kubun]

Could you provide a minimum template which reproduces the problem? I haven't been able to reproduce your problem so far.

$ cat a.haml
:css
$ haml -v
Haml 5.1.2
$ haml a.haml
<style>

</style>

[k0kubun]

Well, looks like I merged a patch which fixed the issue 😅 #986

[k0kubun]

So please try the latest Haml.