Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CSS class names containing the @ sign ("commercial at", U+0040) #867

Merged
merged 1 commit into from Apr 18, 2017

Conversation

redoPop
Copy link
Contributor

@redoPop redoPop commented Feb 19, 2016

CSS conventions including BEMIT encourage use of the @ sign in CSS class names as part of a suffix indicating the breakpoint at which a class takes effect.

This PR adds Haml support for @ within class names, so we can do:

.o-media@md

Instead of having to do:

%div{class: 'o-media@md'}

A passing test is included.

@k0kubun
Copy link
Member

k0kubun commented Apr 18, 2017

Since @ doesn't conflict with Haml syntax other than Ruby's ivars and the naming is totally valid in CSS, I think there's no problem to have this change. Merging for BEMIT naming convention users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants