Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement translate_location for error highlighting on templates #1122

Open
eileencodes opened this issue Jan 13, 2023 · 0 comments
Open

Implement translate_location for error highlighting on templates #1122

eileencodes opened this issue Jan 13, 2023 · 0 comments

Comments

@eileencodes
Copy link

Hello!

@tenderlove and I recently implemented the ability for error highlight to highlight the errors in templates. (see ruby/error_highlight#26, ruby/ruby#6703, rails/rails#46171, and finally rails/rails#46908).

In order for haml to get the underlining on template errors, translate_location needs to be implemented. I've added a deprecation warning to Rails so that other templating engines will see this (but I wanted to open an issue for you as well).

The translate location from Rails is defined here and called from here.

Let me know if I can clarify anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant