Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveSupport::SafeBuffer from .html_safe behaves weirdly #165

Open
gyfis opened this issue Jul 30, 2019 · 0 comments
Open

ActiveSupport::SafeBuffer from .html_safe behaves weirdly #165

gyfis opened this issue Jul 30, 2019 · 0 comments

Comments

@gyfis
Copy link

gyfis commented Jul 30, 2019

Hi, I have a simple .haml file in rails:

- title = "<b>The dog</b> ate her cat's lunch"

.js-tooltip{title: title}
  Dog 1
.js-tooltip{title: title.html_safe}
  Dog 2

When observing the source code, the first <div> gets transformed and escaped properly and behaves as expected:

<div class='js-tooltip' title='&lt;b&gt;The dog&lt;/b&gt; ate her cat&#39;s lunch'>
  Dog 1
</div>

image

However, the second <div> gets transformed and escaped poorly, leading to an unfortunate accident that could have been avoided:

<div class='js-tooltip' title='<b>The dog</b> ate her cat's lunch'>
  Dog 2
</div>

image

It seems that haml-rails doesn't properly deal with ActiveSupport::SafeBuffer in element attributes (this bug doesn't occur when using = title).

Let me know if I can provide more info or examples!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant