Fix some issues with 1.4 on older Rubies #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halostatue
commented
Jun 28, 2020
- Required to fully support rspec. - Resolves #63.
halostatue
force-pushed
the
fix-ruby-1.8-support
branch
from
3e5eb3b
to
2a9a662
Compare
Closed
|
This PR works for the older Rubies in our CI |
|
Thanks, @JonRowe. I have released 1.4.3 that restores compatibility with Ruby 1.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JonRowe If you can test this, I can release it soon.
I ran tests in a docker environment:
This will allow your PR in rspec/rspec-support#421 to be simplified at least a little bit, because the changes for Ruby 1.8 should also improve compatibility for Ruby 1.9.