linux/gamepad: Do not fail on EPERM return values. #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hajimehoshi
reviewed
Sep 5, 2022
| @@ -105,7 +105,7 @@ func (*nativeGamepadsImpl) openGamepad(gamepads *gamepads, path string) (err err | |||
|
|
|||
| fd, err := unix.Open(path, unix.O_RDONLY|unix.O_NONBLOCK, 0) | |||
| if err != nil { | |||
| if err == unix.EACCES { | |||
| if err == unix.EACCES || err == unix.EPERM { | |||
| return nil | |||
| } | |||
| // This happens just after a disconnection. | |||
There was a problem hiding this comment.
Let's add a comment like this
if err == unix.EACCES {
return nil
}
// This happens with the Snap sandbox (#2307)
if err == unix.EPERM {
return nil
}
This seems required for the snap sandbox when probing a non-gamepad device node. Fixes hajimehoshi#2307.
hajimehoshi
pushed a commit
that referenced
this pull request
Sep 6, 2022
This seems required for the Snap sandbox when probing a non-gamepad device node. Closes #2307
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to happen inside the Snap sandbox when accessing a non-gamepad /dev/input device.