Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fully, nested, and semi string type commnets get ignored. #156

Merged
merged 1 commit into from Jul 16, 2022

Conversation

hadialqattan
Copy link
Owner

@hadialqattan hadialqattan commented Jul 16, 2022

Examples:

from typing import List
from ast import Import

foo = [Import(...)]  # type: List['Import']
bar = [Import(...)]  # type: "List['Import']"
baz = [Import(...)]  # type: "List[Import]"

@hadialqattan hadialqattan added this to In progress in Bug Fixing via automation Jul 16, 2022
@codeclimate
Copy link

codeclimate bot commented Jul 16, 2022

Code Climate has analyzed commit 1724020 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #156 (1724020) into master (907b865) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         2850      2850           
=========================================
  Hits          2850      2850           
Impacted Files Coverage Δ
tests/test_scan.py 100.00% <ø> (ø)
pycln/utils/scan.py 100.00% <100.00%> (ø)

@hadialqattan hadialqattan merged commit da19fa1 into master Jul 16, 2022
@hadialqattan hadialqattan deleted the str_type_comments branch July 16, 2022 17:53
Bug Fixing automation moved this from In progress to Done Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Bug Fixing
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant