Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of Kamereon (i.e. model-neutral) code into own package? #836

Open
michaelaye opened this issue Apr 4, 2023 · 0 comments
Open

Comments

@michaelaye
Copy link

Hi there!
I see that you put a lot of effort into this project, including its own sub-package for talking to the Kamereon servers alone.
I was wondering if it is possible, and maybe then should be done, to split off the Kamereon package so that model specific apps/packages could be developed based on that?

From some of your and other comments in the issue I could gather, that it is impossible to know (lacking docs) which endpoints are available for which cars.
This sounds to me that different cars most likely will/should have very different quality of implementation level, just depending on how much volunteer time was spent; and in these cases it might help with the organization that the most stable code (I am hoping that that's the code how to create sessions talking with Kamereon) is split off and the heavy dev is done in "car-packages".

But, i might be totally wrong, as I didn't have too much time to look at all the stuff you implemented. For example, there are even more sub-packages, and I don't know how interlocked that all is, maybe rendering a clean separation of Kamereon and car-specific code impossible?

Let me know what you think.
Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant