New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display range and total mileage in miles with en_GB locale set #186

Open

TheBluProject opened this issue Feb 3, 2021 · 1 comment

Labels

enhancement help wanted

TheBluProject commented Feb 3, 2021 •

edited

With locale en_GB set, Range estimate and Total mileage still displaying in kilometers

epenet added enhancement help wanted labels

Collaborator

epenet commented Feb 3, 2021

It shouldn't be based on locale, but should be an independent option. I'm open to PR...

You can take a look at https://github.com/hacf-fr/renault-api/blob/main/src/renault_api/cli/__main__.py#L150 for adding options to CLI.
And you can take a look at https://github.com/hacf-fr/renault-api/blob/main/src/renault_api/cli/renault_vehicle.py#L25 for retrieving an option (I'm not sure it's necessary to prompt - probably just default back to km if it isn't set)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment