Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypermodern python setup #18

Open
6 of 8 tasks
oncleben31 opened this issue Jul 2, 2020 · 2 comments · Fixed by #20 or #21
Open
6 of 8 tasks

Hypermodern python setup #18

oncleben31 opened this issue Jul 2, 2020 · 2 comments · Fixed by #20 or #21
Assignees
@oncleben31
Labels
enhancement New feature or request

Comments

@oncleben31
Copy link
Member

oncleben31 commented Jul 2, 2020 •
edited

Is your feature request related to a problem? Please describe.
Development environment setting rely on lot of manual tasks. Same thing for tests and linting.

Describe the solution you'd like
Apply the best practice from Hypermodern Python blog posts based on poetry and nox.

  • implement poetry
  • implement nox
  • implement lint checks
  • implement type hint checks
  • implement documentation for code
  • implement documentation for test
  • implement best practice for tests
  • improve CI/CD

Describe alternatives you've considered
N/A

Additional context
N/A
@oncleben31 oncleben31 added the enhancement New feature or request label Jul 2, 2020
@oncleben31 oncleben31 self-assigned this Jul 2, 2020
@oncleben31 oncleben31 mentioned this issue Jul 26, 2020
Merged
@oncleben31 oncleben31 linked a pull request Jul 27, 2020 that will close this issue
Migrate to Poetry #20
Merged
oncleben31 added a commit that referenced this issue Jul 27, 2020
@oncleben31
Merge pull request #20 from hacf-fr/poetry
3ca77ef 
Migrate to Poetry.

Contribute to #18
@oncleben31
Copy link
Member Author

Not fully processed

@oncleben31 oncleben31 reopened this Jul 27, 2020
@oncleben31 oncleben31 linked a pull request Jul 28, 2020 that will close this issue
Migrate tests and lint suite to Nox #21
Merged
@oncleben31 oncleben31 reopened this Jul 28, 2020
@oncleben31 oncleben31 mentioned this issue Jul 29, 2020
Merged
oncleben31 added a commit that referenced this issue Jul 29, 2020
@oncleben31
Add various lint check in pre-commit and Nox sessions (#22)
09eabbb 
To ensure code formatting consistencies and identify early potential bug or security issues. Participate to #18

* Add pre-commit in dev dependencies

* Migrate lint check in pre-commit

It will allow to use the pre-commit hook in the future.

* Fix typo in documentation

* Add pre-commit-hooks in dev dependencies

* Add balck in dev dependencies

* Add black in pre-commit conf

* Add black in lint Nox session

* Add pre-commit-hooks checks

* Fix end of files

* Add reorder_python_imports in dev dependencies

* Add reorder-python-imports check

* Reorder all imports with nox

* Add flake8-bugbear in dev dependencies

* Add flake8-bugbear in pre-commit nox session

* Add flake8-bandit in dev dependencies

* Add flake8-bandit in pre-commit nox session

* Add safety in dev dependencies

* Add safety in nox sessions

* Add pep8-naming in dev dependencies

* Add pep8-naming check in pre-commit nox session

* Remove old lint session in Nox

* Add prettier in pre-commit config

* Change var variable name to be compliant with pep8
R -> radius

* Fix formatting by prettier

* Update contributing documentation about pre-commit
@oncleben31 oncleben31 mentioned this issue Aug 4, 2020
Merged
This was referenced Oct 3, 2020
Merged
Merged
@oncleben31
Copy link
Member Author

CI/CD done partially. Need to check the documentation build automation. But have to wait for the merge of #33 before.

This was referenced Oct 12, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oncleben31 oncleben31

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@oncleben31