Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored linuxParameters after service update #43

Open
vtatarin opened this issue Nov 11, 2018 · 1 comment
Open

Ignored linuxParameters after service update #43

vtatarin opened this issue Nov 11, 2018 · 1 comment

Comments

@vtatarin
Copy link

vtatarin commented Nov 11, 2018

Hi! Thank you for developing such a great tool.

However, after switching from using tini in our containers to embedded initProcessEnabled docker parameter I have discovered the following issue:

after updating any ECS service with ecs-goploy (and ecs-deploy too) linuxParameters section of task definition (which contains the needed initProcessEnabled parameter) is set to null. See example below.

before ecs-goploy:

"linuxParameters": {
        "capabilities": null,
        "sharedMemorySize": null,
        "tmpfs": null,
        "devices": null,
        "initProcessEnabled": true
      }

after updating the service:

"linuxParameters": null
@h3poteto
Copy link
Owner

Hmm... ecs-goploy does not change linuxParameters in current task definition. Probably AWS API updates the section to default value when create a new task definition.
So we have to override it with current value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants