Reduced code smell #3090
Reduced code smell #3090
Conversation
There was a problem hiding this comment.
Thanks, but I don't see any reason in rearrangement of modifiers, such changes only create a noise in the history. New order isn't better than old one.
Code in h2/src/tools with exception for build package also doesn't need any changes, because it's just a playground. This code isn't used anywhere.
| @@ -881,7 +881,7 @@ static String getDataTypeRegistrationKey(DataType<?> dataType) { | |||
| registerDataType(getKeyType()); | |||
| } | |||
| if (getValueType() == null) { | |||
| setValueType((DataType<? super V>) new VersionedValueType<V,Object>(defaultDataType)); | |||
| setValueType((DataType<? super V>) new VersionedValueType<>(defaultDataType)); | |||
There was a problem hiding this comment.
After this change cast also needs to be removed to avoid compiler warning.
There was a problem hiding this comment.
Sorry but, I have rebuilt H2 with maven and I have not seen the warning.
Hi all modifications are code cleanup, not optimizations. I have run some static code analyzer that suggests some modification in order to reduce code smell and use standard code practice. These modifications don't improve the program, only allow to have a better code quality. For this reason, you can, obviously, reject all the push or keep only part of the push (for example the Unused local variable (S1481)). all the best |
|
I took some non-controversial peaces to master as part of #3210 |
I have clean up some code smell
I hope this may be useful for this project