Break compilation on SGX and 32-bit x86 without SSE (fixes #41) #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this! It's pretty rare to have 32bit environments today anyways (especially without SSE), and the poor souls that have to run these machines probably aren't running rust based software on it -- so this seems like a good fix to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible fix for #41.
Unfortunately this would break compilation for 32-bit targets without SSE, a few of which would support CPUID. Proper runtime detection would look like https://doc.rust-lang.org/stable/src/core/up/up/stdarch/crates/core_arch/src/x86/cpuid.rs.html#110-156, but needs C again, to accomplish it on stable Rust.