Replace sha1(uniqid()) by bin2hex(random_bytes(20))
#538
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output size and format is identical, but `random_bytes()` provides much better randomness than `uniqid()` even with the $more_entropy parameter which adds only 32 Bits of entropy on top of the current (micro)time which is more or less known externally. For MultipartStream that might result in a guessable boundary, which might allow an attacker to modify the semantics of an outgoing request with a well-crafted file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output size and format is identical, but
random_bytes()provides much better randomness thanuniqid()even with the $more_entropy parameter which adds only 32 Bits of entropy on top of the current (micro)time which is more or less known externally.For MultipartStream that might result in a guessable boundary, which might allow an attacker to modify the semantics of an outgoing request with a well-crafted file.