Skip to content

Replace Header::normalize() by Header::splitList() in README #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

TimWolla
Copy link

splitList() is a replacement for normalize(). It was forgotten to adjust
the README.md in #477.

`splitList()` is a replacement for `normalize()`. It was forgotten to adjust
the README.md in guzzle#477.
@GrahamCampbell
Copy link
Member

Can we document both please? Maybe indicate which of them is preferred?

@TimWolla
Copy link
Author

Can we document both please?

We could, but normalize() should not really appear in new code and for old code it still has PHPDoc for your IDE.

I can re-add normalize() with a deprecation note, if you insist.

@GrahamCampbell
Copy link
Member

Yeh, we should document the deprecated stuff too, but just make sure it's noted as deprecated.

@TimWolla
Copy link
Author

TimWolla commented Sep 5, 2022

Yeh, we should document the deprecated stuff too, but just make sure it's noted as deprecated.

@GrahamCampbell Apologies for the delay, now done!

@GrahamCampbell GrahamCampbell merged commit df63a75 into guzzle:master Oct 24, 2022
@TimWolla TimWolla deleted the splitList-readme branch October 24, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants