Add @return to define the return type for non-PHP 7.2 compatible types
#444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
requested changes
Sep 18, 2021
wouterj
force-pushed
the
phpdoc-return
branch
from
070d911
to
7b659c9
Compare
GrahamCampbell
approved these changes
Sep 18, 2021
There was a problem hiding this comment.
Thanks for taking the time to prepare this PR. It's much appreciated. I'll leave this for @Nyholm to review and merge. :)
|
@Nyholm I am also unsure if we want to back-port this to 1.x too. We do have another "final, actually final this time 🧌" release upcoming for that series. |
Nyholm
approved these changes
Sep 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the return type for methods implementing PSR-7 interfaces, but where the return type is not compatible with PHP 7.2.
Besides making the return type more descriptive when reading the method definition, this also suppresses type deprecation notices when using guzzle/psr7 with Symfony 5.4+.