Add additional URL resolver test case #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
GrahamCampbell
approved these changes
Sep 26, 2021
Tobion
reviewed
Oct 9, 2021
| @@ -124,6 +124,8 @@ public function getResolveTestCases(): iterable | |||
| // path ending with slash or no slash at all | |||
| ['http://a/b/c/d/', 'e', 'http://a/b/c/d/e'], | |||
| ['urn:no-slash', 'e', 'urn:e'], | |||
| // path ending without slash and multi-segment relative part | |||
| ['http://a/b/c', 'd/e', 'http://a/b/d/e'], | |||
There was a problem hiding this comment.
This is a duplicate of the test in line 106. So we would not have needed this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a single additional testcase as described in the related issue.
Closes #433.