New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BC Break] trimHeaderValues in 1.6 Release #282
Comments
Symfony BrowserKit does not use psr7. How does the boolean |
I think I hit the same problem. In 1.6 |
According to PSR-7 header values must be strings or arrays of strings. 1.6.0 enforces that. While it might be a break from a library point of view, this library is a PSR-7 implementation. Relying on undocumented features is never a good idea. @Tobion IMHO we should add a warning to the release section saying that this release might break for users not following the PSR-7 specification. |
Fix in #283 |
IMHO that should only be the solution, if we add back the assertions to 2.x |
Yes that's a possibility. But let's not do it in 1.6 as it has only been released for 1 day and several people are affected. So more people will follow otherwise. |
I disagree it's a BC break. Because the param type was That said, for reasons of practicality, it doesn't make sense to break the Symfony code when there's a simple way to get the old behaviour back. ;) |
☝️ |
Fixed in #283 |
With the new release, all headers are getting asserted by its type. Having said that, this introduces a BC break. Symfony's Browserkit Client for example, passes the
https
value as a boolean type:https://github.com/symfony/symfony/blob/38b9b951a42b908fd7e7e9651e41209bc7e620d1/src/Symfony/Component/BrowserKit/AbstractBrowser.php#L385
After updating guzzlehttp/psr7 to 1.6, this request will fail.
The text was updated successfully, but these errors were encountered: