Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL-encodes the userInfo component of an URI #253

Merged
merged 4 commits into from Dec 28, 2018
Merged

URL-encodes the userInfo component of an URI #253

merged 4 commits into from Dec 28, 2018

Conversation

cedx
Copy link
Contributor

@cedx cedx commented Dec 21, 2018

Fixes #252

Tobion
Tobion reviewed Dec 24, 2018
View reviewed changes
src/Uri.php Outdated Show resolved Hide resolved
Tobion
Tobion reviewed Dec 24, 2018
View reviewed changes
src/Uri.php Outdated Show resolved Hide resolved
Tobion
Tobion requested changes Dec 24, 2018
View reviewed changes
Copy link
Member

@Tobion Tobion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

Tobion
Tobion requested changes Dec 26, 2018
View reviewed changes
src/Uri.php Show resolved Hide resolved
@Tobion Tobion merged commit ae7949e into guzzle:master Dec 28, 2018
@Tobion
Copy link
Member

Tobion commented Dec 28, 2018

Thank you @cedx

@sagikazarmark sagikazarmark mentioned this pull request Jul 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobion Tobion Tobion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cedx @Tobion