Fix subsequent reads from php://input in ServerRequest #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the PHP documentation reading from the same php://input stream is not possible. Even reading from separate streams is SAPI dependent. http://php.net/manual/de/wrappers.php.php#wrappers.php.input This change adds a CachingStream wrapping the default stream when using ServerRequest::fromGlobals to allow subsequent reads.
Nyholm
approved these changes
Feb 20, 2019
|
Clever solution 👍 @sagikazarmark |
LeSuisse
added a commit
to Enalean/tuleap
that referenced
this pull request
Feb 10, 2020
A change is made to the FileUploadController so the implementation of the TusServer can continue to work. In guzzle/psr7#247 [0] the default body of the ServerRequest has been switched to a CachingStream which is nice until you need to use StreamInterface::detach() because only already cached data will be available. Forcing data to be put in cache is not interesting here because we want to save as much as data as possible from the client even if we only got a part of it (resuming the upload will be dealt with the tus protocol). To avoid that, we now recreate a StreamInterface directly from the php://input resource when uploading a file with tus. [0] guzzle/psr7#247 Change-Id: I167bac3958ffdec37d8b4cf8860d70d73befe3a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the PHP documentation reading from the same php://input
stream is not possible. Even reading from separate streams is
SAPI dependent.
http://php.net/manual/de/wrappers.php.php#wrappers.php.input
This change adds a CachingStream wrapping the default stream
when using ServerRequest::fromGlobals to allow subsequent
reads.
Fixes #186