only close curl handle if it's done.

[divinity76]

this is a copy of PR #2892

quoting bagder:

Can I object to the closing of this PR? I'm the main author of libcurl and I wrote this API. It is clearly documented to return a CURLMSG_DONE for this case and only then does it mean that a handle/transfer is complete. Not checking for that value works only by chance and will break in the case libcurl adds another message.

If you're not going to listen to badger, the guy who wrote libcurl, then there's no hope.

that said, another option would be to throw a LogicException instead, something along the line of

            if ($done['msg'] !== \CURLMSG_DONE) {
                throw new \LogicException("unknown message received from libcurl. only CURLMSG_DONE is supported. received ".$msg['msg'] );
            }

but.. just ignoring unknown messages is the least destructive approach.

[divinity76]

Nice to see it fixed. While we're on the subject, i wonder if a E_USER_WARNING about unknown-ignored message would be appropriate, but won't waste much more time thinking about it

[GrahamCampbell]

Thanks @divinity76. 🍻