Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced implicit URI to string coercion #2946

Merged
merged 1 commit into from Dec 6, 2021
Merged

Replaced implicit URI to string coercion #2946

merged 1 commit into from Dec 6, 2021

Conversation

GrahamCampbell
Copy link
Member

When we eventually turn on strict typing, this would have caused issues.

Nyholm
Nyholm approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 01611d9 into master Dec 6, 2021
@Nyholm Nyholm deleted the uri-coercion branch December 6, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GrahamCampbell @Nyholm