Be more strict with types #2914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure getMaxAge() always returns null or int. Also trigger deprecations if wrong types are passed to SetCookie
|
We should probably turn off the authoritative phpdoc types setting in phpstan (or whatever it's called). |
|
Yeah... But I rather just add this to the baseline. Note how I prepare the user and code for version 8. |
|
Ok, sure. Re-gen the baseline then. |
|
Baseline is updated and the CI is green. |
GrahamCampbell
requested changes
Jul 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure getMaxAge() always returns null or int. Also trigger deprecations if wrong types are passed to SetCookie
This will fix #2888