idn_to_ascii() fix for old PHP versions #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you have a look why the build fails? |
alexeyshockov
force-pushed
the
idna-variant-2003-fix
branch
from
26bfff3
to
bb7be43
Compare
gmponos
approved these changes
Dec 23, 2019
alexeyshockov
force-pushed
the
idna-variant-2003-fix
branch
from
bb7be43
to
72341dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2488
https://3v4l.org/NgNZa is an example of the issue. This feature is hard to test on different PHP version with different extensions/libs...