Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom option for cURL multi handler #2287

Merged
merged 2 commits into from Oct 23, 2019
Merged

Custom option for cURL multi handler #2287

merged 2 commits into from Oct 23, 2019

Conversation

alexeyshockov
Copy link
Collaborator

@alexeyshockov alexeyshockov commented Apr 15, 2019 •
edited by Nyholm

Custom options for cURL multi handler, allowing to configure a handle from curl_multi_init(). Something like 'curl' request options, to fix #2248, for example.

@alexeyshockov alexeyshockov mentioned this pull request Apr 15, 2019
Closed
kkopachev
kkopachev reviewed Jun 10, 2019
View reviewed changes
docs/faq.rst Outdated Show resolved Hide resolved
@alexeyshockov alexeyshockov mentioned this pull request Jul 8, 2019
Closed
@alexeyshockov alexeyshockov force-pushed the curl-multi-options branch 2 times, most recently from 27df4df to 8010664 Compare July 9, 2019 08:09
@alexeyshockov
Copy link
Collaborator Author

So tests are failing because of the issues in master (#2327 probably should fix it). Otherwise the feature is ready.

@Gemorroj
Copy link

@sagikazarmark ping

@alexeyshockov alexeyshockov force-pushed the curl-multi-options branch 3 times, most recently from fe66dcf to 89b4a6e Compare October 14, 2019 11:49
@alexeyshockov
Copy link
Collaborator Author

@sagikazarmark, could you take a look at this for the next release?

Nyholm
Nyholm approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.
I think this looks good. But I would like an other review on it.

@Nyholm Nyholm added this to the 6.5.0 milestone Oct 18, 2019
@sagikazarmark sagikazarmark self-requested a review October 18, 2019 13:18
sagikazarmark
sagikazarmark approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Nyholm Nyholm merged commit 8f10d0e into guzzle:master Oct 23, 2019
@alexeyshockov alexeyshockov deleted the curl-multi-options branch October 23, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkopachev kkopachev kkopachev left review comments

@sagikazarmark sagikazarmark sagikazarmark approved these changes

@Nyholm Nyholm Nyholm approved these changes

@darvids0n darvids0n darvids0n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

429 - to many requests
6 participants
@alexeyshockov @Gemorroj @sagikazarmark @Nyholm @darvids0n @kkopachev