New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add invalid argument exception #2163
Add invalid argument exception #2163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one minor comment, apart from that 👍
|
||
namespace GuzzleHttp\Exception; | ||
|
||
class InvalidArgumentException extends \InvalidArgumentException implements GuzzleException {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this class should be final for now, we can always open it up later.
Also, please add a trailing new line to the end of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.. I added the new line but I am not sure if it is visible through the PR changes tab
Looks good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks good as always @gmponos ! Thanks! |
Hello @gmponos, i create a fork of this repo and release this marge request into the new version(6.4.0). Namespace compatibility is 100%, and you can use my changes if you patch composer.json in your projects
Fork link: https://github.com/SomeBlackMagic/guzzle/ |
Hello there,
Let's say I have the following class:
when I call the function above I have to do something like this:
This has the defect that I if another part of my code throws an
InvalidArgumentException
inside this class I can not separate it from the the GuzzleHttpInvalidArgumentException
.