Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup environment variables #2161

Merged
merged 2 commits into from Dec 21, 2018

Conversation

casconed
Copy link
Contributor

@casconed casconed commented Oct 4, 2018

Add support for already-documented variable GUZZLE_CURL_SELECT_TIMEOUT , and add additional documentation for NO_PROXY

@FrontEndCoffee
Copy link
Contributor

I am personally not a fan of else and elseif statements, but I don't see how in this situation the readability could be improved without adding additional methods (and thus complication).

Looks good 👍

Copy link
Member

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @casconed

@sagikazarmark sagikazarmark merged commit 330dc56 into guzzle:master Dec 21, 2018
@wirwolf
Copy link

wirwolf commented Oct 18, 2019

Hello @casconed, i create a fork of this repo and release this marge request into the new version(6.4.0).

Namespace compatibility is 100%, and you can use my changes if you patch composer.json in your projects

  • replace "guzzlehttp/guzzle": "^6.3" to "someblackmagic/guzzle": "^6.4"
  • add "guzzlehttp/guzzle": "6.3.*" into replace block

Fork link: https://github.com/SomeBlackMagic/guzzle/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants