Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failed to open stream to ConnectException #2012

Merged
merged 2 commits into from Mar 26, 2018

Conversation

sm2017
Copy link
Contributor

@sm2017 sm2017 commented Feb 14, 2018

When connect_timeout is reached I see the following error but isConnectionError is false

Error creating resource: [message] fopen(url): failed to open stream: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

@kstich
Copy link

kstich commented Feb 15, 2018

failed to open stream can happen for a multitude of reasons. It seems pretty explicitly safe to use connection attempt failed as the determining factor here.

@sagikazarmark
Copy link
Member

@kstich sounds better

connection attempt failed
@sm2017
Copy link
Contributor Author

sm2017 commented Feb 16, 2018

@kstich thank you

@sm2017
Copy link
Contributor Author

sm2017 commented Feb 21, 2018

@guzzle Can you accept the PR?

@sagikazarmark
Copy link
Member

Will be reviewed when someone gets there, but I wouldn't expect it to be released for another few weeks. There are some other changes in the pipe too.

@sagikazarmark sagikazarmark added this to the 6.3.1 milestone Mar 26, 2018
@sagikazarmark
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants