Error with malformed domain that contains a "/" character

[curtisdf]

Cookies where the domain contains a "/" character are triggering an exception with SetCookie::matchesDomain(). The issue is that the call to preg_quote() inside this function does not specify the regex delimiter being used, and so this character isn't getting escaped, which leads to a malformed pattern going into preg_match(). This can be triggered for example if the cookie improperly contains a URL, or if it appends a path after the hostname, such as in the following examples:

foo=bar; domain=example.com/

foo=bar; domain=http://www.example.com

[curtisdf]

This is interesting. Evidently this bug was fixed 4 years ago, but somehow the fix was reverted. See #526. The fix is legit though. preg_quote() really does need to be told which delimiter to use.

Also, #1720 is in reference to the same bug.

[GrahamCampbell]

👍

[sagikazarmark]

Thanks!