Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper service headers modification #1916

Merged
merged 1 commit into from Mar 26, 2018

Conversation

alexeyshockov
Copy link
Collaborator

Fixes #1913

@sagikazarmark sagikazarmark self-requested a review February 5, 2018 01:47
@sagikazarmark sagikazarmark added this to the 6.3.1 milestone Mar 26, 2018
@sagikazarmark
Copy link
Member

Thanks a lot!

@CmdrSharp
Copy link

CmdrSharp commented Apr 27, 2019

This seems to break my unit tests. It seems anything currently sending over JSON formatted information now returns Undefined index: _conditional.

EDIT: Found the cause.
Previously, if specifying a headers-param by default with a null value, it was not a problem. After this commit, I found I'd instead have to pass an empty array for assertions to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multipart Content-Type vs. content-type
3 participants