docs: Pin Jinja2 & markupsafe #3063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The used Sphinx versions use APIs from Jinja2 and markupsafe that don't exist anymore and the build fails. With these pins it works again.
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm the maintainer of doc2dash, a tool to create browsable docsets from Sphinx documentation. One of your users asked for help on my bug tracker about converting your docs and while trying to reproduce, I've noticed that the documentation doesn't build with the pins that you have in your
requirements.txtbecause Jinja2 and markupsafe broke some backwards-compatability.With the two I'm adding here, it works again.
I've noticed you're not building your docs in CI, so generally speaking if you have any questions that someone a bit more intimate with Python, docs, and packaging feel free to ask.
Cheers