Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison in testParseCookie #2977

Merged
merged 1 commit into from Mar 13, 2022
Merged

Fix comparison in testParseCookie #2977

merged 1 commit into from Mar 13, 2022

Conversation

villfa
Copy link
Contributor

@villfa villfa commented Jan 7, 2022

Fixes #2894

@villfa villfa mentioned this pull request Jan 7, 2022
Closed
@sualko
Copy link

sualko commented Jan 7, 2022

Thanks for providing this fix. It's much more readable 👍

Nyholm
Nyholm approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

This is 9 year old code you fixed =)

@Nyholm Nyholm merged commit 802ecc6 into guzzle:master Mar 13, 2022
@villfa villfa deleted the patch-1 branch March 13, 2022 19:15
@FelixJacobi FelixJacobi mentioned this pull request Mar 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo or PHP voodoo magic?
3 participants
@villfa @sualko @Nyholm