RequestOptions::JSON => $body doesn't add Content Type and Accept to body anymore

[aligajani]

Guzzle version(s) affected: ^6.3.1
PHP version: 7.3.2 (hint: php --version)
cURL version: 7.65.3 (hint: php -i | grep cURL)

Description
So I ran composer update a few hours ago and now RequestOptions::JSON => $body doesn't add Content Type and Accept to body anymore. When I run the following, it simply returns the HTML response on the API I am hitting because it expects JSON in the Content Type and Accept, which I thought the RequestOptions::JSON is intended to supply out of the box.

 logger('POST', compact('body', 'endpoint'));
            $client = new Client();

            $response = $client->post($this->apiUrl . $endpoint, [
                'headers'            => [
                    'Authorization' => 'Bearer' . " " . $this->apiKey
                ],
                RequestOptions::JSON => $body
            ]);

            logger($response->getHeaders());

[Nyholm]

Let’s add the content type in guzzle 8

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 2 weeks if no further activity occurs. Thank you for your contributions.

[mfn]

Maybe stale bot shouldn't process issues added to milestones

[guilliamxavier]

RequestOptions::JSON has never added the Accept header, cf its phpDoc:

json: (mixed) Adds JSON data to a request. The provided value is JSON encoded and a Content-Type header of application/json will be added to the request if no Content-Type header is already present.

As for the Content-Type, there was a possibly related change in 6.3.1 (#1916), but I just checked that it is correctly added in 6.5.5 for your example

[GrahamCampbell]

There is a lifecycle label for this. :)

[guilliamxavier]

To be clear, I didn't mean to have it reopened. For me there is no bug.