From 802ecc6e56b38709120da07e7de50355c2e378d9 Mon Sep 17 00:00:00 2001 From: Fabien Villepinte Date: Sun, 13 Mar 2022 16:54:35 +0100 Subject: [PATCH] Fix comparison in testParseCookie (#2977) --- tests/Cookie/SetCookieTest.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/Cookie/SetCookieTest.php b/tests/Cookie/SetCookieTest.php index b1bf55f28..98268bfca 100644 --- a/tests/Cookie/SetCookieTest.php +++ b/tests/Cookie/SetCookieTest.php @@ -373,11 +373,11 @@ public function testParseCookie($cookie, $parsed) $p = $c->toArray(); if (isset($p['Expires'])) { - // Remove expires values from the assertion if they are relatively equal - if (\abs($p['Expires'] != \strtotime($parsed['Expires'])) < 40) { - unset($p['Expires']); - unset($parsed['Expires']); - } + $delta = 40; + $parsedExpires = \is_numeric($parsed['Expires']) ? $parsed['Expires'] : \strtotime($parsed['Expires']); + self::assertLessThan($delta, \abs($p['Expires'] - $parsedExpires), 'Comparing Expires ' . \var_export($p['Expires'], true) . ' : ' . \var_export($parsed, true) . ' | ' . \var_export($p, true)); + unset($p['Expires']); + unset($parsed['Expires']); } if (!empty($parsed)) {