Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config_protoc test doesn't account for XDG_CACHE_HOME #270

Closed
Oiyoo opened this issue Oct 14, 2019 · 0 comments · Fixed by #271
Closed

config_protoc test doesn't account for XDG_CACHE_HOME #270

Oiyoo opened this issue Oct 14, 2019 · 0 comments · Fixed by #271

Comments

@Oiyoo
Copy link
Contributor

Oiyoo commented Oct 14, 2019

--- FAIL: TestScripts (0.00s)
--- FAIL: TestScripts/config_protoc (17.99s)
testscript.go:308:
# TODO: use [!net] once it does something useful.
# See rogpeppe/go-internal#75. (0.000s)
# Use a separate $HOME, to not reuse a cached protoc. (0.000s)
# Specify a valid protoc version.
#
# Note that the parent gunkconfig uses an invalid
# version but since it's overriden by any existing child config
# (i.e. here and in the succeeding tests) nothing blows up (17.977s)
> gunk generate ./version
> exists $CACHEDIR/gunk/protoc-v3.8.0
FAIL: testdata/scripts/config_protoc.txt:15: $WORK/protoc_home//snap/code/common/.cache/gunk/protoc-v3.8.0 does not exist

FAIL
FAIL github.com/gunk/gunk 20.980s
@Oiyoo Oiyoo changed the title config_protoc test doesn config_protoc test doesn't account for XDG_CACHE_HOME Oct 14, 2019
Oiyoo added a commit to Oiyoo/gunk that referenced this issue Oct 14, 2019
@Oiyoo
testdata/scripts: accounts for XDG_CACHE_HOME
8d5350b 
test was failing due to having `XDG_CACHE_HOME` set locally, but not in
the test case, resulting in a discrepancy

sets the env var on the test, and while at it, also includes
`LocalAppData` for windows and `home` for plan9

ref: https://github.com/golang/go/blob/902d5aa84f8340752c20b93bfd450a6cefcf3952/src/os/file.go#L371

fixes gunk#270
@Oiyoo Oiyoo mentioned this issue Oct 14, 2019
Merged
mvdan pushed a commit that referenced this issue Oct 15, 2019
@Oiyoo @mvdan
testdata/scripts: accounts for XDG_CACHE_HOME
48654f6 
test was failing due to having `XDG_CACHE_HOME` set locally, but not in
the test case, resulting in a discrepancy

sets the env var on the test, and while at it, also includes
`LocalAppData` for windows and `home` for plan9

ref: https://github.com/golang/go/blob/902d5aa84f8340752c20b93bfd450a6cefcf3952/src/os/file.go#L371

fixes #270
ghazninattarshah pushed a commit to ghazninattarshah/gunk that referenced this issue Nov 1, 2019
@Oiyoo @ghazninattarshah
testdata/scripts: accounts for XDG_CACHE_HOME
30ef036 
test was failing due to having `XDG_CACHE_HOME` set locally, but not in
the test case, resulting in a discrepancy

sets the env var on the test, and while at it, also includes
`LocalAppData` for windows and `home` for plan9

ref: https://github.com/golang/go/blob/902d5aa84f8340752c20b93bfd450a6cefcf3952/src/os/file.go#L371

fixes gunk#270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

testdata/scripts: accounts for XDG_CACHE_HOME Oiyoo/gunk
1 participant
@Oiyoo